simbabug.txt 1.8 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253
  1. Most 14 version of "landmod.f90"
  2. --------------------------------
  3. 1594 dnpp(:) = 0.
  4. 1595 dgpp(:) = 0.
  5. 1596 dgppl(:) = 0.
  6. 1597 dgppw(:) = 0.
  7. 1598 dvwmax(:) = dwmax(:)
  8. 1599
  9. 1600 where (dls(:) > 0. .and. dglac(:) == 0.)
  10. The bug is a missing line at 1599 like:
  11. dvfor(:) = dforest(:)
  12. The purpose was to work with local copies of the arrays
  13. "dwmax" and "dforest". So the original arrays would be
  14. unaffected if NBIOME was set to 0 (no interaction).
  15. The bug had the effect that "dvfor" started with the
  16. initialized values of zero after every restart,
  17. because "dforest" was read from the restart file
  18. but not copied to "dvfor".
  19. The current version Most15 with the corresponding code
  20. fragment is now:
  21. Most15 version of "simba.f90"
  22. -----------------------------
  23. 113 ! Following plasim arrays are used but not modified
  24. 114 ! -------------------------------------------------
  25. 115 ! dwatc(:) = soil wetness [m]
  26. 116 ! dgppl(:) = GPP light limited
  27. 117 ! dswfl(:) = short wave radiation [W/m2]
  28. 118 ! devap(:) = surface evaporation (negative)
  29. 119
  30. 120 ! Make local copies of some plasim arrays
  31. 121 ! They are copied back if NBIOME is set to 1 (interactive)
  32. 122
  33. 123 zforest(:) = dforest(:) ! Forest cover (0.0 - 1.0)
  34. 124 zwmax(:) = dwmax(:) ! Bucket depth
  35. 125
  36. 126 dnpp(:) = 0.0 ! Net primary production [kg C m-2 s-1]
  37. 127 dgpp(:) = 0.0 ! Gross primary production [kg C m-2 s-1]
  38. 128 dgppw(:) = 0.0 ! GPP water limited
  39. 129
  40. 130 where (dls(:) > 0.0 .and. dglac(:) == 0.0) ! land cell with no glacier
  41. "dvwmax" was renamed to "zwmax" and
  42. "dvfor" to "zforest" following the coding rules for the Planet Simulator.
  43. This and the new comments should clarify the roles of these arrays.